File headers in file OK
Create Branches for sw360
Avoid (serious) compiler warnings
No breaking test
New test
Documentation
Commit style
Review basically checks for the D-o-D items, in particular
All files contributed require headers - this will ensure the license and copyright clearing at the end. Also, all contributions must have the same license as the original source.
If a file has relevant functionality, note that we should move to Eclipse 2.0
/*
* Copyright COPYRIGHT HOLDER, 2017.
* Copyright NEXT COPYRIGHT HOLDER, 2017.
* Part of the SW360 Portal Project.
*
* SPDX-License-Identifier: EPL-2.0
*
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v2.0
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v20.html
*/
(please adapt comment characters usage)
For small files such as property files, configuration files or standard XML files:
# Copyright <COPYRIGHT_HOLDER>, <YEAR>. Part of the SW360 Portal Project.
#
# All rights reserved. This configuration file is provided to you under the
# terms and conditions of the Eclipse Distribution License v1.0 which
# accompanies this distribution, and is available at
# http://www.eclipse.org/org/documents/edl-v10.php
Just use the standard Java formatting rules of your IDE and do not reformat code from others, because you like to correct formatting of other’s code.